-
Notifications
You must be signed in to change notification settings - Fork 319
Use ClassLoaderIndex to index class-loader related information
#9980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mcculls
wants to merge
1
commit into
master
Choose a base branch
from
mcculls/use-classloader-index
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.11 s) : 0, 1110455
Total [baseline] (8.874 s) : 0, 8874387
Agent [candidate] (1.103 s) : 0, 1103095
Total [candidate] (8.855 s) : 0, 8855330
section iast
Agent [baseline] (1.244 s) : 0, 1244457
Total [baseline] (9.555 s) : 0, 9554662
Agent [candidate] (1.24 s) : 0, 1239797
Total [candidate] (9.558 s) : 0, 9557937
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.506 ms) : 0, 1506
crashtracking [candidate] (1.499 ms) : 0, 1499
BytebuddyAgent [baseline] (713.876 ms) : 0, 713876
BytebuddyAgent [candidate] (708.985 ms) : 0, 708985
GlobalTracer [baseline] (251.164 ms) : 0, 251164
GlobalTracer [candidate] (249.613 ms) : 0, 249613
AppSec [baseline] (32.394 ms) : 0, 32394
AppSec [candidate] (32.006 ms) : 0, 32006
Debugger [baseline] (63.628 ms) : 0, 63628
Debugger [candidate] (63.548 ms) : 0, 63548
Remote Config [baseline] (622.319 µs) : 0, 622
Remote Config [candidate] (614.46 µs) : 0, 614
Telemetry [baseline] (8.316 ms) : 0, 8316
Telemetry [candidate] (8.202 ms) : 0, 8202
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.665 ms) : 0, 3665
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (837.01 ms) : 0, 837010
BytebuddyAgent [candidate] (832.224 ms) : 0, 832224
GlobalTracer [baseline] (237.517 ms) : 0, 237517
GlobalTracer [candidate] (238.019 ms) : 0, 238019
IAST [baseline] (27.346 ms) : 0, 27346
IAST [candidate] (29.429 ms) : 0, 29429
AppSec [baseline] (34.036 ms) : 0, 34036
AppSec [candidate] (32.168 ms) : 0, 32168
Debugger [baseline] (60.302 ms) : 0, 60302
Debugger [candidate] (60.019 ms) : 0, 60019
Remote Config [baseline] (544.963 µs) : 0, 545
Remote Config [candidate] (543.715 µs) : 0, 544
Telemetry [baseline] (7.633 ms) : 0, 7633
Telemetry [candidate] (7.551 ms) : 0, 7551
Flare Poller [baseline] (3.436 ms) : 0, 3436
Flare Poller [candidate] (3.444 ms) : 0, 3444
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.106 s) : 0, 1106178
Total [baseline] (10.89 s) : 0, 10889889
Agent [candidate] (1.108 s) : 0, 1107984
Total [candidate] (10.956 s) : 0, 10955650
section appsec
Agent [baseline] (1.289 s) : 0, 1289110
Total [baseline] (11.122 s) : 0, 11121580
Agent [candidate] (1.288 s) : 0, 1288382
Total [candidate] (11.11 s) : 0, 11109859
section iast
Agent [baseline] (1.241 s) : 0, 1240868
Total [baseline] (11.32 s) : 0, 11320418
Agent [candidate] (1.241 s) : 0, 1240972
Total [candidate] (11.272 s) : 0, 11272481
section profiling
Agent [baseline] (1.233 s) : 0, 1233436
Total [baseline] (11.126 s) : 0, 11126103
Agent [candidate] (1.236 s) : 0, 1236194
Total [candidate] (11.191 s) : 0, 11191267
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.499 ms) : 0, 1499
crashtracking [candidate] (1.504 ms) : 0, 1504
BytebuddyAgent [baseline] (710.72 ms) : 0, 710720
BytebuddyAgent [candidate] (713.162 ms) : 0, 713162
GlobalTracer [baseline] (250.027 ms) : 0, 250027
GlobalTracer [candidate] (249.377 ms) : 0, 249377
AppSec [baseline] (32.139 ms) : 0, 32139
AppSec [candidate] (31.91 ms) : 0, 31910
Debugger [baseline] (64.349 ms) : 0, 64349
Debugger [candidate] (64.27 ms) : 0, 64270
Remote Config [baseline] (635.516 µs) : 0, 636
Remote Config [candidate] (634.414 µs) : 0, 634
Telemetry [baseline] (8.279 ms) : 0, 8279
Telemetry [candidate] (8.331 ms) : 0, 8331
Flare Poller [baseline] (3.675 ms) : 0, 3675
Flare Poller [candidate] (3.828 ms) : 0, 3828
section appsec
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (735.18 ms) : 0, 735180
BytebuddyAgent [candidate] (735.107 ms) : 0, 735107
GlobalTracer [baseline] (242.422 ms) : 0, 242422
GlobalTracer [candidate] (242.131 ms) : 0, 242131
IAST [baseline] (24.981 ms) : 0, 24981
IAST [candidate] (24.948 ms) : 0, 24948
AppSec [baseline] (175.399 ms) : 0, 175399
AppSec [candidate] (175.564 ms) : 0, 175564
Debugger [baseline] (61.675 ms) : 0, 61675
Debugger [candidate] (61.283 ms) : 0, 61283
Remote Config [baseline] (689.01 µs) : 0, 689
Remote Config [candidate] (659.114 µs) : 0, 659
Telemetry [baseline] (8.336 ms) : 0, 8336
Telemetry [candidate] (8.343 ms) : 0, 8343
Flare Poller [baseline] (3.92 ms) : 0, 3920
Flare Poller [candidate] (3.908 ms) : 0, 3908
section iast
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (832.969 ms) : 0, 832969
BytebuddyAgent [candidate] (832.789 ms) : 0, 832789
GlobalTracer [baseline] (237.932 ms) : 0, 237932
GlobalTracer [candidate] (237.969 ms) : 0, 237969
IAST [baseline] (28.98 ms) : 0, 28980
IAST [candidate] (29.059 ms) : 0, 29059
AppSec [baseline] (32.267 ms) : 0, 32267
AppSec [candidate] (32.369 ms) : 0, 32369
Debugger [baseline] (60.774 ms) : 0, 60774
Debugger [candidate] (60.692 ms) : 0, 60692
Remote Config [baseline] (541.92 µs) : 0, 542
Remote Config [candidate] (549.403 µs) : 0, 549
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.624 ms) : 0, 7624
Flare Poller [baseline] (3.463 ms) : 0, 3463
Flare Poller [candidate] (3.515 ms) : 0, 3515
section profiling
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (735.669 ms) : 0, 735669
BytebuddyAgent [candidate] (736.063 ms) : 0, 736063
GlobalTracer [baseline] (222.184 ms) : 0, 222184
GlobalTracer [candidate] (222.845 ms) : 0, 222845
AppSec [baseline] (32.212 ms) : 0, 32212
AppSec [candidate] (32.346 ms) : 0, 32346
Debugger [baseline] (63.128 ms) : 0, 63128
Debugger [candidate] (63.357 ms) : 0, 63357
Remote Config [baseline] (658.461 µs) : 0, 658
Remote Config [candidate] (648.724 µs) : 0, 649
Telemetry [baseline] (8.013 ms) : 0, 8013
Telemetry [candidate] (7.959 ms) : 0, 7959
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.768 ms) : 0, 3768
ProfilingAgent [baseline] (97.237 ms) : 0, 97237
ProfilingAgent [candidate] (98.744 ms) : 0, 98744
Profiling [baseline] (97.826 ms) : 0, 97826
Profiling [candidate] (99.353 ms) : 0, 99353
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (17.885 ms) : 17705, 18065
. : milestone, 17885,
appsec (18.751 ms) : 18561, 18942
. : milestone, 18751,
code_origins (17.679 ms) : 17503, 17856
. : milestone, 17679,
iast (18.602 ms) : 18415, 18788
. : milestone, 18602,
profiling (19.983 ms) : 19780, 20187
. : milestone, 19983,
tracing (17.643 ms) : 17467, 17819
. : milestone, 17643,
section candidate
no_agent (17.935 ms) : 17755, 18114
. : milestone, 17935,
appsec (18.715 ms) : 18528, 18902
. : milestone, 18715,
code_origins (17.403 ms) : 17229, 17577
. : milestone, 17403,
iast (18.687 ms) : 18497, 18876
. : milestone, 18687,
profiling (18.366 ms) : 18184, 18548
. : milestone, 18366,
tracing (17.541 ms) : 17369, 17713
. : milestone, 17541,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (1.214 ms) : 1202, 1226
. : milestone, 1214,
iast (3.256 ms) : 3209, 3304
. : milestone, 3256,
iast_FULL (5.791 ms) : 5733, 5849
. : milestone, 5791,
iast_GLOBAL (3.534 ms) : 3484, 3584
. : milestone, 3534,
profiling (2.089 ms) : 2071, 2108
. : milestone, 2089,
tracing (1.848 ms) : 1833, 1863
. : milestone, 1848,
section candidate
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.087 ms) : 3047, 3128
. : milestone, 3087,
iast_FULL (5.614 ms) : 5558, 5669
. : milestone, 5614,
iast_GLOBAL (3.563 ms) : 3508, 3618
. : milestone, 3563,
profiling (1.98 ms) : 1962, 1998
. : milestone, 1980,
tracing (1.869 ms) : 1853, 1885
. : milestone, 1869,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (14.775 s) : 14775000, 14775000
. : milestone, 14775000,
iast (18.337 s) : 18337000, 18337000
. : milestone, 18337000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
. : milestone, 17902000,
profiling (14.734 s) : 14734000, 14734000
. : milestone, 14734000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
section candidate
no_agent (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
appsec (14.699 s) : 14699000, 14699000
. : milestone, 14699000,
iast (18.613 s) : 18613000, 18613000
. : milestone, 18613000,
iast_GLOBAL (17.91 s) : 17910000, 17910000
. : milestone, 17910000,
profiling (14.549 s) : 14549000, 14549000
. : milestone, 14549000,
tracing (14.684 s) : 14684000, 14684000
. : milestone, 14684000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~0efba487f6, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.656 ms) : 3440, 3871
. : milestone, 3656,
iast (2.216 ms) : 2152, 2281
. : milestone, 2216,
iast_GLOBAL (2.25 ms) : 2185, 2315
. : milestone, 2250,
profiling (2.09 ms) : 2036, 2144
. : milestone, 2090,
tracing (2.041 ms) : 1990, 2091
. : milestone, 2041,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.699 ms) : 3478, 3919
. : milestone, 3699,
iast (2.208 ms) : 2144, 2273
. : milestone, 2208,
iast_GLOBAL (2.251 ms) : 2186, 2316
. : milestone, 2251,
profiling (2.071 ms) : 2018, 2123
. : milestone, 2071,
tracing (2.044 ms) : 1993, 2094
. : milestone, 2044,
|
09616cc to
10d8418
Compare
5f70d32 to
d182ada
Compare
d182ada to
0efba48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: performance
Performance related changes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]